]> dgit.raspbian.org Git - gnome-shell.git/commitdiff
notificationDaemon: Namespace private `sender-pid` hint
authorFlorian Müllner <fmuellner@gnome.org>
Tue, 20 Feb 2024 18:39:31 +0000 (19:39 +0100)
committerFlorian Müllner <fmuellner@gnome.org>
Tue, 20 Feb 2024 20:09:32 +0000 (21:09 +0100)
The hint is a private implementation detail between the public
and internal services, not something anybody else should set
(*cough* libnotify *cough*).

Prefix the name to hopefully make that clearer.

Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/3204>

js/dbusServices/notifications/notificationDaemon.js
js/ui/notificationDaemon.js

index f824f813d871faaa389f727a898da672883e46ef..473b0c4c03c4be9c393eda7fba245bb231dfaf56 100644 (file)
@@ -100,7 +100,7 @@ export const NotificationDaemon = class extends ServiceImplementation {
 
         params[6] = {
             ...hints,
-            'sender-pid': new GLib.Variant('u', pid),
+            'x-shell-sender-pid': new GLib.Variant('u', pid),
         };
 
         try {
index 1f68a1c54d854a4e790cdad7d7d75a7a21d7921c..4c6437a8cf2569b0c9f908f71e780ec0698e1c0b 100644 (file)
@@ -162,7 +162,7 @@ class FdoNotificationDaemon {
         this._notifications[id] = ndata;
 
         let sender = invocation.get_sender();
-        let pid = hints['sender-pid'];
+        const pid = hints['x-shell-sender-pid'];
 
         let source = this._getSource(appName, pid, ndata, sender, null);
         this._notifyForSource(source, ndata);